Skip to content

Conversation

@lenemter
Copy link
Member

@lenemter lenemter commented Jun 9, 2025

elementary/notifications#237 is not resolved and therefore this looks ugly on some locales

@lenemter lenemter requested a review from a team June 9, 2025 20:35
@lenemter lenemter mentioned this pull request Jun 9, 2025
2 tasks
@lenemter lenemter merged commit 0c0447b into main Jun 9, 2025
4 of 5 checks passed
@lenemter lenemter deleted the lenemter/remove-show-in-photos-action branch June 9, 2025 20:47
@danirabbit
Copy link
Member

Tbh I would have preferred to remove the show in files button since you can show in files from within the photo viewer and opening in photos gives you more immediate options for cropping etc that folks had previously asked for in screenshot

@Marukesu
Copy link
Contributor

Marukesu commented Jun 9, 2025

I'm a little late in both PRs, but we could set "open in photos" as the default action instead of using a button, Then we don't need to translate any string, nor have a button that could break the notification layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants